Skip to content

feat(adk): support skill #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
meguminnnnnnnnn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(adk): support skill #661

meguminnnnnnnnn wants to merge 1 commit into from
+1,161 −0

Conversation

@meguminnnnnnnnn
Copy link
Contributor

@meguminnnnnnnnn meguminnnnnnnnn commented Jan 4, 2026

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@codecov
Copy link

codecov bot commented Jan 4, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 79.22078% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.36%. Comparing base (d11713a) to head (52ba06d).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
adk/middlewares/skill/skill.go 67.08% 13 Missing and 13 partials ⚠️
adk/middlewares/skill/local.go 92.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
+ Coverage   80.31%   80.36%   +0.04%     
==========================================
  Files         124      126       +2     
  Lines       11904    12060     +156     
==========================================
+ Hits         9561     9692     +131     
- Misses       1613     1621       +8     
- Partials      730      747      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@turingboot
Copy link

turingboot commented Jan 6, 2026

hi team！thanks for ur works. When is this skills feature roughly expected to be merged? This is a promising feature, and we look forward to its integration.

@hi-pender
Copy link
Contributor

hi-pender commented Jan 7, 2026

hi team！thanks for ur works. When is this skills feature roughly expected to be merged? This is a promising feature, and we look forward to its integration.

it maybe released on the end of this week

@meguminnnnnnnnn meguminnnnnnnnn force-pushed the feat/wdz/adk_skill branch 5 times, most recently from 2dec249 to ca307c3 Compare January 9, 2026 03:44
hi-pender
hi-pender reviewed Jan 9, 2026
View reviewed changes
adk/middlewares/skill/prompt.go
</skills_instructions>
`
skillToolDescriptionTemplate = `
Copy link
Contributor

@hi-pender hi-pender Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skill 中需要包含 skillPath， skill 的使用，可能会涉及 skillPath 下的 assets、scripts、references 目录
Image

Copy link
Contributor

@hi-pender hi-pender Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑到模型使用 skill 的场景，下面这俩抽象确实不够。 skill 使用时，可能会需要 read、bash 等工具

Image

hi-pender
hi-pender reviewed Jan 9, 2026
View reviewed changes
hi-pender
hi-pender reviewed Jan 9, 2026
View reviewed changes
@turingboot
Copy link

turingboot commented Jan 13, 2026

hi team！thanks for ur works. When is this skills feature roughly expected to be merged? This is a promising feature, and we look forward to its integration.

it maybe released on the end of this week

I noticed the PR is still pending review. Would you be able to share a rough timeline for when it might be merged?
Thank you for your effort on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hi-pender hi-pender hi-pender approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@meguminnnnnnnnn @turingboot @hi-pender